Skip to content

Revert "[css-animation-1] Handle <string> values in keyframes-name as identitiers" #12996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

Revert "[css-animation-1] Handle <string> values in keyframes-name as identitiers" #12996

merged 1 commit into from
Oct 21, 2025

Conversation

@javifernandez
Copy link
Contributor

@javifernandez javifernandez commented Oct 21, 2025

Reverts #12985

One implemented suggested to revert, based on a disagreement of the CSSWG resolution.

Loirooriol
Loirooriol approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@Loirooriol Loirooriol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I guess it's better to revert until it's clarified what the resolution meant.

@javifernandez javifernandez merged commit 4001c55 into main Oct 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Loirooriol Loirooriol Loirooriol approved these changes

@fantasai fantasai Awaiting requested review from fantasai

@tabatkins tabatkins Awaiting requested review from tabatkins

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@javifernandez @Loirooriol